-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Update GitHub, GitLab, BitBucket copy #3603
base: main
Are you sure you want to change the base?
Conversation
Bundle ReportBundle size has no change ✅ |
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3603 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 810 810
Lines 14562 14562
Branches 4148 4141 -7
=======================================
Hits 14414 14414
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3603 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 810 810
Lines 14562 14562
Branches 4148 4141 -7
=======================================
Hits 14414 14414
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3603 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 810 810
Lines 14562 14562
Branches 4148 4141 -7
=======================================
Hits 14414 14414
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3603 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 810 810
Lines 14562 14562
Branches 4148 4141 -7
=======================================
Hits 14414 14414
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
…zebo into rvinnakota/login-copy
…ota/login-copy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be useful to introduce an enum that holds the correct spelling for GH so it's seamlessly consistent everywhere it's used?
The providers enum should hold the correct value, and it updates appropriate locations where it's used with this change. I will look into creating an eslint rule as a follow up to see if we can better enforce this. |
Initially intended to fix copy on the login screen. Updated elsewhere as well.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.