Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Update GitHub, GitLab, BitBucket copy #3603

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Dec 20, 2024

Initially intended to fix copy on the login screen. Updated elsewhere as well.

Screenshot 2025-01-03 at 11 47 20 AM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Dec 20, 2024

Bundle Report

Bundle size has no change ✅

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

@codecov-staging
Copy link

codecov-staging bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3603   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      810           
  Lines       14562    14562           
  Branches     4148     4141    -7     
=======================================
  Hits        14414    14414           
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
.../InstallationHelpBanner/InstallationHelpBanner.jsx 100.00% <100.00%> (ø)
...ts/Header/components/UserDropdown/UserDropdown.tsx 100.00% <100.00%> (ø)
...hubIntegrationSection/GithubIntegrationSection.jsx 100.00% <ø> (ø)
...odecovAIPage/InstallCodecovAI/InstallCodecovAI.tsx 100.00% <100.00%> (ø)
...e/CommitCoverage/BotErrorBanner/BotErrorBanner.jsx 100.00% <ø> (ø)
...rc/pages/DefaultOrgSelector/DefaultOrgSelector.jsx 100.00% <100.00%> (ø)
...tOrgSelector/GitHubHelpBanner/GitHubHelpBanner.tsx 100.00% <100.00%> (ø)
...rBanners/GithubConfigBanner/GithubConfigBanner.jsx 100.00% <100.00%> (ø)
...c/pages/RepoPage/CoverageOnboarding/NewRepoTab.tsx 100.00% <100.00%> (ø)
...ateLimitExceeded/GitHubRateLimitExceededBanner.tsx 100.00% <100.00%> (ø)
... and 4 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <100.00%> (ø)
Pages 98.72% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.37% <100.00%> (ø)
UI 99.14% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7722e18...caf84b8. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (7722e18) to head (caf84b8).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3603   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      810           
  Lines       14562    14562           
  Branches     4148     4141    -7     
=======================================
  Hits        14414    14414           
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
.../InstallationHelpBanner/InstallationHelpBanner.jsx 100.00% <100.00%> (ø)
...ts/Header/components/UserDropdown/UserDropdown.tsx 100.00% <100.00%> (ø)
...hubIntegrationSection/GithubIntegrationSection.jsx 100.00% <ø> (ø)
...odecovAIPage/InstallCodecovAI/InstallCodecovAI.tsx 100.00% <100.00%> (ø)
...e/CommitCoverage/BotErrorBanner/BotErrorBanner.jsx 100.00% <ø> (ø)
...rc/pages/DefaultOrgSelector/DefaultOrgSelector.jsx 100.00% <100.00%> (ø)
...tOrgSelector/GitHubHelpBanner/GitHubHelpBanner.tsx 100.00% <100.00%> (ø)
...rBanners/GithubConfigBanner/GithubConfigBanner.jsx 100.00% <100.00%> (ø)
...c/pages/RepoPage/CoverageOnboarding/NewRepoTab.tsx 100.00% <100.00%> (ø)
...ateLimitExceeded/GitHubRateLimitExceededBanner.tsx 100.00% <100.00%> (ø)
... and 4 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <100.00%> (ø)
Pages 98.72% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.37% <100.00%> (ø)
UI 99.14% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7722e18...caf84b8. Read the comment docs.

Copy link

codecov-public-qa bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (7722e18) to head (caf84b8).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3603   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      810           
  Lines       14562    14562           
  Branches     4148     4141    -7     
=======================================
  Hits        14414    14414           
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
.../InstallationHelpBanner/InstallationHelpBanner.jsx 100.00% <100.00%> (ø)
...ts/Header/components/UserDropdown/UserDropdown.tsx 100.00% <100.00%> (ø)
...hubIntegrationSection/GithubIntegrationSection.jsx 100.00% <ø> (ø)
...odecovAIPage/InstallCodecovAI/InstallCodecovAI.tsx 100.00% <100.00%> (ø)
...e/CommitCoverage/BotErrorBanner/BotErrorBanner.jsx 100.00% <ø> (ø)
...rc/pages/DefaultOrgSelector/DefaultOrgSelector.jsx 100.00% <100.00%> (ø)
...tOrgSelector/GitHubHelpBanner/GitHubHelpBanner.tsx 100.00% <100.00%> (ø)
...rBanners/GithubConfigBanner/GithubConfigBanner.jsx 100.00% <100.00%> (ø)
...c/pages/RepoPage/CoverageOnboarding/NewRepoTab.tsx 100.00% <100.00%> (ø)
...ateLimitExceeded/GitHubRateLimitExceededBanner.tsx 100.00% <100.00%> (ø)
... and 4 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <100.00%> (ø)
Pages 98.72% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.37% <100.00%> (ø)
UI 99.14% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7722e18...caf84b8. Read the comment docs.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (7722e18) to head (caf84b8).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3603   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      810           
  Lines       14562    14562           
  Branches     4148     4141    -7     
=======================================
  Hits        14414    14414           
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
.../InstallationHelpBanner/InstallationHelpBanner.jsx 100.00% <100.00%> (ø)
...ts/Header/components/UserDropdown/UserDropdown.tsx 100.00% <100.00%> (ø)
...hubIntegrationSection/GithubIntegrationSection.jsx 100.00% <ø> (ø)
...odecovAIPage/InstallCodecovAI/InstallCodecovAI.tsx 100.00% <100.00%> (ø)
...e/CommitCoverage/BotErrorBanner/BotErrorBanner.jsx 100.00% <ø> (ø)
...rc/pages/DefaultOrgSelector/DefaultOrgSelector.jsx 100.00% <100.00%> (ø)
...tOrgSelector/GitHubHelpBanner/GitHubHelpBanner.tsx 100.00% <100.00%> (ø)
...rBanners/GithubConfigBanner/GithubConfigBanner.jsx 100.00% <100.00%> (ø)
...c/pages/RepoPage/CoverageOnboarding/NewRepoTab.tsx 100.00% <100.00%> (ø)
...ateLimitExceeded/GitHubRateLimitExceededBanner.tsx 100.00% <100.00%> (ø)
... and 4 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <100.00%> (ø)
Pages 98.72% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.37% <100.00%> (ø)
UI 99.14% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7722e18...caf84b8. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Dec 20, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
7b79594 Fri, 20 Dec 2024 21:56:40 GMT Expired Expired
7b79594 Fri, 20 Dec 2024 21:57:53 GMT Expired Expired
7b79594 Fri, 20 Dec 2024 21:58:05 GMT Expired Expired
0949928 Fri, 20 Dec 2024 22:06:47 GMT Expired Expired
ae8e693 Fri, 03 Jan 2025 15:36:32 GMT Expired Expired
caf84b8 Fri, 03 Jan 2025 16:54:12 GMT Cloud Enterprise

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [draft] Update GitHub and GitLab copy [draft] Update GitHub, GitLab, BitBucket copy Jan 3, 2025
@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review January 3, 2025 16:48
@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [draft] Update GitHub, GitLab, BitBucket copy [fix] Update GitHub, GitLab, BitBucket copy Jan 3, 2025
Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be useful to introduce an enum that holds the correct spelling for GH so it's seamlessly consistent everywhere it's used?

@rohitvinnakota-codecov
Copy link
Contributor Author

Would it be useful to introduce an enum that holds the correct spelling for GH so it's seamlessly consistent everywhere it's used?

The providers enum should hold the correct value, and it updates appropriate locations where it's used with this change. I will look into creating an eslint rule as a follow up to see if we can better enforce this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants