-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate orgUploadToken to ts #3602
Conversation
Bundle ReportChanges will decrease total bundle size by 204 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will decrease total bundle size by 204 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3602 +/- ##
=======================================
Coverage 98.98% 98.99%
=======================================
Files 810 810
Lines 14553 14556 +3
Branches 4136 4140 +4
=======================================
+ Hits 14406 14409 +3
Misses 140 140
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
src/pages/AccountSettings/tabs/OrgUploadToken/useGenerateOrgUploadToken.ts
Outdated
Show resolved
Hide resolved
@@ -82,7 +87,7 @@ function RegenerateOrgUploadToken({ orgUploadToken }) { | |||
{showModal && ( | |||
<RegenerateTokenModal | |||
closeModal={() => setShowModal(false)} | |||
regenerateToken={regenerateToken} | |||
regenerateToken={() => Promise.resolve(regenerateToken())} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious as to why you're wrapping this in a Promise.resolve
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was incorrect - I fixed it in the revised version with mutateAsync
because the RegenerateTokenModal wants to await regenerateToken() before closing the modal here
cf75c31
to
9826704
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Migrate orgUploadToken related files to TS
Closes codecov/engineering-team#2859