Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin serde-json and remove json_internal imports #6

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Swatinem
Copy link
Collaborator

@Swatinem Swatinem commented Jun 6, 2024

Also adds a rust-toolchain.toml file so that the rustup wrapper will automatically pick this up, and commits the Cargo.lock file as the conventions regarding that were changed in https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html

Also adds a `rust-toolchain.toml` file so that the `rustup` wrapper will automatically pick this up, and commits the `Cargo.lock` file as the conventions regarding that were changed in https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
@Swatinem Swatinem requested a review from matt-codecov June 6, 2024 07:52
@Swatinem Swatinem self-assigned this Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (d986d4d) to head (f6d7c80).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   98.12%   98.12%   -0.01%     
==========================================
  Files          17       17              
  Lines        6248     6225      -23     
==========================================
- Hits         6131     6108      -23     
  Misses        117      117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@matt-codecov matt-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:o wonder why i pinned it. i feel like it was pinned on the crates.io page when i added it

in any case, thanks for these hygiene changes!

@Swatinem Swatinem merged commit 553307f into main Jun 7, 2024
8 checks passed
@Swatinem Swatinem deleted the swatinem/update-serde branch June 7, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants