-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI and use nextest
#59
Conversation
This updates the CI definitions a bit: - Invokes `rustup` directly instead of using an action - Updates the `setup-python` action to the latest version - Adds a separate `doctest` run to run doctests and emit `cargo doc` errors - Switches to `nextest` for running test, which also has builtin junit output - Always run tests with coverage
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 98.53% 98.52% -0.02%
==========================================
Files 21 21
Lines 6775 6772 -3
==========================================
- Hits 6676 6672 -4
- Misses 99 100 +1
☔ View full report in Codecov by Sentry. |
- uses: taiki-e/install-action@nextest | ||
|
||
# FIXME(swatinem): We should pass `--all-targets` to also compile and tests benchmarks | ||
# Though currently `divan` does not support all CLI arguments as used by `nextest`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you moved us off divan
in another PR, is this still relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I forgot to fix that in the followup PR, will do :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well actually, running the benchmark in test mode runs one iteration of the benchmark. Which won’t complete in any reasonable time in debug builds. So until I make progress on speeding that up, this won’t be feasible until then.
This updates the CI definitions a bit:
rustup
directly instead of using an actionsetup-python
action to the latest versiondoctest
run to run doctests and emitcargo doc
errorsnextest
for running test, which also has builtin junit output