Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI and use nextest #59

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Update CI and use nextest #59

merged 2 commits into from
Nov 19, 2024

Conversation

Swatinem
Copy link
Collaborator

This updates the CI definitions a bit:

  • Invokes rustup directly instead of using an action
  • Updates the setup-python action to the latest version
  • Adds a separate doctest run to run doctests and emit cargo doc errors
  • Switches to nextest for running test, which also has builtin junit output
  • Always run tests with coverage

This updates the CI definitions a bit:

- Invokes `rustup` directly instead of using an action
- Updates the `setup-python` action to the latest version
- Adds a separate `doctest` run to run doctests and emit `cargo doc` errors
- Switches to `nextest` for running test, which also has builtin junit output
- Always run tests with coverage
@Swatinem Swatinem self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.52%. Comparing base (98cb909) to head (ae5e39d).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   98.53%   98.52%   -0.02%     
==========================================
  Files          21       21              
  Lines        6775     6772       -3     
==========================================
- Hits         6676     6672       -4     
- Misses         99      100       +1     
Components Coverage Δ
core 98.60% <ø> (-0.02%) ⬇️
bindings 79.31% <ø> (ø)
python 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- uses: taiki-e/install-action@nextest

# FIXME(swatinem): We should pass `--all-targets` to also compile and tests benchmarks
# Though currently `divan` does not support all CLI arguments as used by `nextest`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you moved us off divan in another PR, is this still relevant?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I forgot to fix that in the followup PR, will do :-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well actually, running the benchmark in test mode runs one iteration of the benchmark. Which won’t complete in any reasonable time in debug builds. So until I make progress on speeding that up, this won’t be feasible until then.

@Swatinem Swatinem merged commit a657c08 into main Nov 19, 2024
9 checks passed
@Swatinem Swatinem deleted the swatinem/update-ci branch November 19, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants