Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct python version in maturin ci for aarch64 #55

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

matt-codecov
Copy link
Collaborator

@matt-codecov matt-codecov commented Sep 24, 2024

tested in #54
filed an issue in maturin about it PyO3/maturin#2227

the publish workflow was generated with maturin generate-ci github --pytest so that pytest would be run for each platform. it worked fine for x86_64 and x86, but for aarch64 it failed with an error:

Looking in links: dist
  ERROR: Could not find a version that satisfies the requirement codecov_rs (from versions: none)
  ERROR: No matching distribution found for codecov_rs

(job link)

the tl;dr is that x86_64 and x86 got to use the Python 3.12 version set up earlier in the workflow but aarch64 had to use Python 3.10 because reasons. we set requires-python = ">=3.12" in pyproject.toml so when we tried to install our wheel on 3.10 it refused.

the fix here is to use the deadsnakes PPA to install a newer version of Python

alternatives:

  • change pyproject.toml to require python >= 3.10 and make maturin build wheels for older versions
  • stop running pytest
  • stop building aarch64

we don't really need linux aarch64 support right now but it would be necessary to integrate codecov-rs in a cli or VS Code extension in the future

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (93e59ef) to head (3aa2c1f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files          21       21           
  Lines        6775     6775           
=======================================
  Hits         6676     6676           
  Misses         99       99           
Components Coverage Δ
core 98.61% <ø> (ø)
bindings 79.31% <ø> (ø)
python 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swatinem
Copy link
Collaborator

we don't really need linux aarch64 support right now

you would if you install/run precompiled binaries in docker on mac

Copy link
Collaborator

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m also okay with not running pytest again on the for-publishing binaries, as it runs for development binaries in CI anyway.

@matt-codecov
Copy link
Collaborator Author

the non-publish CI is only linux so it would not have caught that windows tempfile bug

@matt-codecov matt-codecov merged commit eaeaf7a into main Sep 25, 2024
9 checks passed
@matt-codecov matt-codecov deleted the pr55 branch September 25, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants