-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta(changelog): Update package versions #34
meta(changelog): Update package versions #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall changes seem consistent and logical for a new release of the software. The versions have been updated from '0.0.1-alpha' to '1.0.0'. However, there are some suggestions for the improvement, listed in the comments.
@@ -1,8 +0,0 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deletion of '.changeset/sweet-lemons-add.md' is noticed. If this file was intended to track changes, you may want to consider whether its deletion is beneficial or if there's another change tracking procedure in place.
|
||
### Major Changes | ||
|
||
- 256f916: Initial release of the Codecov JavaScript Bundler Plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit ID '256f916' has been used for the initial release of all modules. While this is not inherently an issue, it would be more informative if unique commit IDs for each specific module were used instead.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/bundler-plugin-core", | |||
"version": "0.0.1-alpha", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no change in the 'name' property in every package.json file. It's good that these package names remain consistent.
|
||
### Major Changes | ||
|
||
- 256f916: Initial release of the Codecov JavaScript Bundler Plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to see an update to the dependencies marked with the ID '256f916' reflected in the rollup-plugin's ChangeLog.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/vite-plugin", | |||
"version": "0.0.1-alpha", | |||
"version": "1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see the version update in the 'vite-plugin' package.json file. Make sure this reflects the changes you've made.
### Patch Changes | ||
|
||
- Updated dependencies [256f916] | ||
- @codecov/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's important to keep the dependencies updated in the webpack-plugin's ChangeLog as well, as seen with '256f916'. Good job on that.
This is only a test PR |
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to quick-fixes-to-release-workflow, this PR will be updated.
Releases
@codecov/[email protected]
Major Changes
@codecov/[email protected]
Major Changes
Patch Changes
@codecov/[email protected]
Major Changes
Patch Changes
@codecov/[email protected]
Major Changes
Patch Changes