Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trent/image ci #25

Merged
merged 17 commits into from
Dec 12, 2023
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .github/workflows/test-api-ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
name: Test API Image CI

on:
push:
branches:
- main
# paths:
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
# - integration-tests/test-api/**
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
pull_request:
# paths:
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
# - integration-tests/test-api/**

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true


jobs:
build:
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
name: Build API Test
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
if: github.event_name != 'push'
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
uses: codecov/gha-workflows/.github/workflows/build-and-push-dockerhub.yml@trent/build-push-dockerhub
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
secrets: inherit
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
with:
push: false
image_name: codecov-javascript-bundler-plugins-test-api
docker_path: integration-tests/test-api
push:
name: Build API Test
if: ${{ github.event_name == 'push' && github.event.ref == 'refs/heads/main' && github.repository_owner == 'codecov' }}
Copy link

@codecov codecov bot Dec 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This expression seems too restrictive. For example, it strictly checks for the repository owner to be 'codecov'. If the repository is forked, the owner would change and this would stop working. Removing ' && github.repository_owner == 'codecov'' might improve flexibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eliatcodecov Medium helpful comment. The bot is probably right here.

uses: codecov/gha-workflows/.github/workflows/build-and-push-dockerhub.yml@trent/build-push-dockerhub
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
secrets: inherit
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
with:
push: true
image_name: codecov-javascript-bundler-plugins-test-api
docker_path: integration-tests/test-api
23 changes: 23 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
DOCKERHUB_REPO ?= codecov
IMAGE_NAME ?= codecov-javascript-bundler-plugins-test-api
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
DOCKER_PATH ?= integration-tests/test-api
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
sha := $(shell git rev-parse --short=7 HEAD)
dockerhub_image := ${DOCKERHUB_REPO}/${IMAGE_NAME}
export DOCKER_BUILDKIT := 1

build.${IMAGE_NAME}:
docker build -f ${DOCKER_PATH}/Dockerfile ${DOCKER_PATH} -t ${dockerhub_image}:latest \
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
-t ${dockerhub_image}:${sha} \
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
--label "org.label-schema.build-date"="$(build_date)" \
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
--label "org.label-schema.name"="${IMAGE_NAME}" \
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
--label "org.label-schema.vendor"="Codecov" \
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
--label "org.label-schema.version"="${sha}"

tag.${IMAGE_NAME}:
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
docker tag ${dockerhub_image}:${sha} ${dockerhub_image}:latest

push.${IMAGE_NAME}:
docker push ${dockerhub_image}:latest
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved

save.${IMAGE_NAME}:
docker save -o ${IMAGE_NAME}.tar ${dockerhub_image}:${sha}
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
trent-codecov marked this conversation as resolved.
Show resolved Hide resolved
Loading