Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add finer Sentry HTTP Tracing #237

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nicholas-codecov
Copy link
Collaborator

@nicholas-codecov nicholas-codecov commented Jan 10, 2025

Description

This PR adds in some extra tracing that's a bit finer grain looking at the specific fetch requests for getting the pre-signed URL, and uploading stats. As well we've added in distributed tracing for getting the pre-signed URL (only when talking to Codecov).

Ticket: codecov/engineering-team#954

Notable Changes

  • Add tracing around getPreSignedURL, and uploadStats fetching

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 93.38843% with 8 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/bundler-plugin-core/src/utils/getPreSignedURL.ts 87.09% 8 Missing ⚠️
Components Coverage Δ
Plugin core 98.04% <93.38%> (-0.17%) ⬇️
Rollup plugin 8.69% <ø> (ø)
Vite plugin 8.69% <ø> (ø)
Webpack plugin 57.69% <ø> (ø)

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 93.38843% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.23%. Comparing base (88c2eb1) to head (f43f629).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/bundler-plugin-core/src/utils/getPreSignedURL.ts 87.09% 8 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
Plugin core 98.04% <93.38%> (-0.17%) ⬇️
Rollup plugin 8.69% <ø> (ø)
Vite plugin 8.69% <ø> (ø)
Webpack plugin 57.69% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented Jan 10, 2025

Bundle Report

Changes will increase total bundle size by 45.56kB (0.73%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/bundler-plugin-core-cjs 65.44kB 1.17kB (1.81%) ⬆️
@codecov/bundler-plugin-core-esm 59.02kB 44.64kB (310.57%) ⬆️
@codecov/vite-plugin-esm 1.24kB 1.41kB (-53.21%) ⬇️
@codecov/bundle-analyzer-esm 3.11kB 347 bytes (-10.05%) ⬇️
@codecov/rollup-plugin-esm 2.66kB 1.36kB (104.15%) ⬆️
@codecov/solidstart-plugin-esm 949 bytes 488 bytes (-33.96%) ⬇️
@codecov/remix-vite-plugin-esm 957 bytes 474 bytes (-33.12%) ⬇️
@codecov/webpack-plugin-esm 3.89kB 499 bytes (14.73%) ⬆️
@codecov/astro-plugin-esm 1.48kB 619 bytes (71.81%) ⬆️
@codecov/example-sveltekit-app-client-esm 727.49kB 2 bytes (-0.0%) ⬇️
@codecov/example-sveltekit-app-server-esm 984.45kB 1 bytes (-0.0%) ⬇️

Copy link

codecov bot commented Jan 10, 2025

Bundle Report

Changes will increase total bundle size by 2.57kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/vite-plugin-esm 2.65kB 1.41kB (113.72%) ⬆️
@codecov/bundler-plugin-core-cjs 65.44kB 1.17kB (1.81%) ⬆️

@nicholas-codecov nicholas-codecov marked this pull request as ready for review January 10, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants