Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve issues with the Local Provider #226

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

nicholas-codecov
Copy link
Collaborator

Description

This PR fixes some conditional checks in the Local provider where values were being set as null then failing the next conditional and breaking uploads on local machines.

Notable Changes

  • Update conditional in Local where we also needed to check for null
  • Add in changeset

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (f00a08f) to head (7062dff).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Plugin core 97.51% <100.00%> (+0.53%) ⬆️
Rollup plugin 10.76% <ø> (ø)
Vite plugin 10.93% <ø> (ø)
Webpack plugin 52.09% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Components Coverage Δ
Plugin core 97.51% <100.00%> (+0.53%) ⬆️
Rollup plugin 10.76% <ø> (ø)
Vite plugin 10.93% <ø> (ø)
Webpack plugin 52.09% <ø> (ø)

📢 Thoughts on this report? Let us know!

@codecov-staging
Copy link

codecov-staging bot commented Dec 9, 2024

Bundle Report

Changes will increase total bundle size by 42.1kB (0.73%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/bundler-plugin-core-cjs 59.03kB 20 bytes (0.03%) ⬆️
@codecov/bundler-plugin-core-esm 53.17kB 40.73kB (327.59%) ⬆️
@codecov/nuxt-plugin-esm 1.23kB 397 bytes (47.83%) ⬆️
@codecov/vite-plugin-esm 2.37kB 1.13kB (91.04%) ⬆️
@codecov/bundle-analyzer-esm 3.45kB 347 bytes (11.17%) ⬆️
@codecov/rollup-plugin-esm 1.3kB 1.07kB (-45.02%) ⬇️
@codecov/sveltekit-plugin-esm 1.09kB 198 bytes (22.22%) ⬆️
@codecov/remix-vite-plugin-esm 1.09kB 133 bytes (13.9%) ⬆️
@codecov/webpack-plugin-esm 3.6kB 209 bytes (6.17%) ⬆️
@codecov/example-sveltekit-app-client-esm 715.09kB 2 bytes (0.0%) ⬆️
@codecov/example-sveltekit-app-server-esm 974.29kB 1 bytes (0.0%) ⬆️

Copy link

codecov bot commented Dec 9, 2024

Bundle Report

Changes will increase total bundle size by 885 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/bundler-plugin-core-cjs 59.03kB 20 bytes (0.03%) ⬆️
@codecov/rollup-plugin-esm 2.37kB 1.07kB (81.87%) ⬆️
@codecov/sveltekit-plugin-esm 891 bytes 198 bytes (-18.18%) ⬇️
@codecov/example-sveltekit-app-client-esm 715.09kB 2 bytes (-0.0%) ⬇️
@codecov/example-sveltekit-app-server-esm 974.29kB 1 bytes (-0.0%) ⬇️

@nicholas-codecov nicholas-codecov merged commit be672d0 into main Dec 9, 2024
66 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-conditionals-in-providers branch December 9, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants