Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Collect dynamicImports in plugins #217

Merged
merged 8 commits into from
Dec 4, 2024
Merged

feat: Collect dynamicImports in plugins #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2966663
add dynamicImports to the Chunk type
nicholas-codecov Dec 2, 2024
966654c
bump schema version to 3
nicholas-codecov Dec 2, 2024
9544296
collect dynamic imports from base bundler plugins
nicholas-codecov Dec 2, 2024
ef2bd5d
update plugin unit test snapshots
nicholas-codecov Dec 2, 2024
c47f7df
update integration tests to expect the dynamicImports array and their…
nicholas-codecov Dec 2, 2024
5297a27
add chalk as a dev dep for the webpack plugin
nicholas-codecov Dec 3, 2024
6847293
address feedback
nicholas-codecov Dec 3, 2024
01a321f
rename arg and add in better comment
nicholas-codecov Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .changeset/tame-glasses-compete.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
"@codecov/nextjs-webpack-plugin": minor
"@codecov/bundler-plugin-core": minor
"@codecov/remix-vite-plugin": minor
"@codecov/solidstart-plugin": minor
"@codecov/sveltekit-plugin": minor
"@codecov/webpack-plugin": minor
"@codecov/rollup-plugin": minor
"@codecov/nuxt-plugin": minor
"@codecov/vite-plugin": minor
---

Collect dynamic imports for base bundler plugins, which apply to the extended meta-framework plugins.
2 changes: 1 addition & 1 deletion ...ate-bundle-stats/bundle-analyzer/dotenv-vercel/__snapshots__/bundle-analyzer.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ exports[`Bundle Analyzer Integration Tests should generate a report and match th
"name": StringMatching "@codecov/bundle-analyzer",
"version": Any<String>,
},
"version": "2",
"version": "3",
}
`;
2 changes: 2 additions & 0 deletions integration-tests/fixtures/generate-bundle-stats/nextjs/nextjs-plugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ describe("Generating nextjs stats", () => {
entry: expect.any(Boolean),
files: expect.arrayContaining([expect.any(String)]),
names: expect.arrayContaining([expect.any(String)]),
dynamicImports: expect.any(Array),
},
]),
modules: expect.arrayContaining([
Expand Down Expand Up @@ -130,6 +131,7 @@ describe("Generating nextjs stats", () => {
entry: expect.any(Boolean),
files: expect.arrayContaining([expect.any(String)]),
names: expect.arrayContaining([expect.any(String)]),
dynamicImports: expect.any(Array),
},
]),
modules: expect.arrayContaining([
Expand Down
36 changes: 18 additions & 18 deletions integration-tests/fixtures/generate-bundle-stats/nuxt/__snapshots__/nuxt-plugin.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ exports[`Generating nuxt stats 3 {"format":"amd","expected":"amd"} matches the s
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -38,7 +38,7 @@ exports[`Generating nuxt stats 3 {"format":"amd","expected":"amd"} matches the s
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -59,7 +59,7 @@ exports[`Generating nuxt stats 3 {"format":"cjs","expected":"cjs"} matches the s
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -80,7 +80,7 @@ exports[`Generating nuxt stats 3 {"format":"cjs","expected":"cjs"} matches the s
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -101,7 +101,7 @@ exports[`Generating nuxt stats 3 {"format":"es","expected":"esm"} matches the sn
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -122,7 +122,7 @@ exports[`Generating nuxt stats 3 {"format":"es","expected":"esm"} matches the sn
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -143,7 +143,7 @@ exports[`Generating nuxt stats 3 {"format":"esm","expected":"esm"} matches the s
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -164,7 +164,7 @@ exports[`Generating nuxt stats 3 {"format":"esm","expected":"esm"} matches the s
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -185,7 +185,7 @@ exports[`Generating nuxt stats 3 {"format":"module","expected":"esm"} matches th
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -206,7 +206,7 @@ exports[`Generating nuxt stats 3 {"format":"module","expected":"esm"} matches th
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -227,7 +227,7 @@ exports[`Generating nuxt stats 3 {"format":"iife","expected":"iife"} matches the
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -248,7 +248,7 @@ exports[`Generating nuxt stats 3 {"format":"iife","expected":"iife"} matches the
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -269,7 +269,7 @@ exports[`Generating nuxt stats 3 {"format":"umd","expected":"umd"} matches the s
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -290,7 +290,7 @@ exports[`Generating nuxt stats 3 {"format":"umd","expected":"umd"} matches the s
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -311,7 +311,7 @@ exports[`Generating nuxt stats 3 {"format":"system","expected":"system"} matches
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -332,7 +332,7 @@ exports[`Generating nuxt stats 3 {"format":"system","expected":"system"} matches
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -353,7 +353,7 @@ exports[`Generating nuxt stats 3 {"format":"systemjs","expected":"system"} match
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -374,6 +374,6 @@ exports[`Generating nuxt stats 3 {"format":"systemjs","expected":"system"} match
"name": StringMatching "@codecov/nuxt-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;
2 changes: 2 additions & 0 deletions integration-tests/fixtures/generate-bundle-stats/nuxt/nuxt-plugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ describe("Generating nuxt stats", () => {
entry: expect.any(Boolean),
files: expect.arrayContaining([expect.any(String)]),
names: expect.arrayContaining([expect.any(String)]),
dynamicImports: expect.any(Array),
},
]),
modules: expect.arrayContaining([
Expand Down Expand Up @@ -135,6 +136,7 @@ describe("Generating nuxt stats", () => {
entry: expect.any(Boolean),
files: expect.arrayContaining([expect.any(String)]),
names: expect.arrayContaining([expect.any(String)]),
dynamicImports: expect.any(Array),
},
]),
modules: expect.arrayContaining([
Expand Down
20 changes: 10 additions & 10 deletions ...ration-tests/fixtures/generate-bundle-stats/remix/__snapshots__/remix-plugin.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ exports[`Generating remix stats 2 {"format":"amd","expected":"amd"} matches the
"name": StringMatching "@codecov/remix-vite-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -38,7 +38,7 @@ exports[`Generating remix stats 2 {"format":"amd","expected":"amd"} matches the
"name": StringMatching "@codecov/remix-vite-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -59,7 +59,7 @@ exports[`Generating remix stats 2 {"format":"cjs","expected":"cjs"} matches the
"name": StringMatching "@codecov/remix-vite-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -80,7 +80,7 @@ exports[`Generating remix stats 2 {"format":"cjs","expected":"cjs"} matches the
"name": StringMatching "@codecov/remix-vite-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -101,7 +101,7 @@ exports[`Generating remix stats 2 {"format":"es","expected":"esm"} matches the s
"name": StringMatching "@codecov/remix-vite-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -122,7 +122,7 @@ exports[`Generating remix stats 2 {"format":"es","expected":"esm"} matches the s
"name": StringMatching "@codecov/remix-vite-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -143,7 +143,7 @@ exports[`Generating remix stats 2 {"format":"esm","expected":"esm"} matches the
"name": StringMatching "@codecov/remix-vite-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -164,7 +164,7 @@ exports[`Generating remix stats 2 {"format":"esm","expected":"esm"} matches the
"name": StringMatching "@codecov/remix-vite-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -185,7 +185,7 @@ exports[`Generating remix stats 2 {"format":"module","expected":"esm"} matches t
"name": StringMatching "@codecov/remix-vite-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;

Expand All @@ -206,6 +206,6 @@ exports[`Generating remix stats 2 {"format":"module","expected":"esm"} matches t
"name": StringMatching "@codecov/remix-vite-plugin",
"version": "1.5.1",
},
"version": "2",
"version": "3",
}
`;
2 changes: 2 additions & 0 deletions integration-tests/fixtures/generate-bundle-stats/remix/remix-plugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ describe("Generating remix stats", () => {
entry: expect.any(Boolean),
files: expect.arrayContaining([expect.any(String)]),
names: expect.arrayContaining([expect.any(String)]),
dynamicImports: expect.any(Array),
},
]),
modules: expect.arrayContaining([
Expand Down Expand Up @@ -130,6 +131,7 @@ describe("Generating remix stats", () => {
entry: expect.any(Boolean),
files: expect.arrayContaining([expect.any(String)]),
names: expect.arrayContaining([expect.any(String)]),
dynamicImports: expect.any(Array),
},
]),
modules: expect.arrayContaining([
Expand Down
Loading
Loading