Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused regex escape char #211

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

nicholas-codecov
Copy link
Collaborator

Description

Quick PR to remove an unused regex escape char in normalizePath function.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.06%. Comparing base (dc4032a) to head (a5fa2cd).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Plugin core 97.02% <100.00%> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 49.88% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Components Coverage Δ
Plugin core 97.02% <100.00%> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 49.88% <ø> (ø)

📢 Thoughts on this report? Let us know!

@codecov-staging
Copy link

codecov-staging bot commented Nov 19, 2024

Bundle Report

Changes will decrease total bundle size by 216 bytes (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/nuxt-plugin-esm 830 bytes 397 bytes (-32.36%) ⬇️
@codecov/vite-plugin-esm 2.33kB 1.09kB (88.05%) ⬆️
@codecov/rollup-plugin-esm 1.3kB 1.03kB (-44.14%) ⬇️
@codecov/remix-vite-plugin-esm 1.09kB 133 bytes (13.9%) ⬆️
@codecov/webpack-plugin-esm 3.36kB 14 bytes (-0.42%) ⬇️

Copy link

codecov bot commented Nov 19, 2024

Bundle Report

Changes will decrease total bundle size by 132 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/remix-vite-plugin-esm 957 bytes 133 bytes (-12.2%) ⬇️
@codecov/example-sveltekit-app-server-esm 974.29kB 1 bytes (0.0%) ⬆️

@nicholas-codecov nicholas-codecov merged commit 8f89fd4 into main Nov 21, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the int-956-remove-unused-regex-escape-char branch November 21, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants