-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bundle names not being reset properly #209
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files
☔ View full report in Codecov by Sentry. |
packages/bundler-plugin-core/src/utils/__tests__/Output.test.ts
Outdated
Show resolved
Hide resolved
packages/bundler-plugin-core/src/utils/__tests__/Output.test.ts
Outdated
Show resolved
Hide resolved
@@ -43,7 +43,7 @@ export const nextJSWebpackBundleAnalysisPlugin: ExtendedBAUploadPlugin<{ | |||
stage: webpack.Compilation.PROCESS_ASSETS_STAGE_REPORT, | |||
}, | |||
async () => { | |||
output.setBundleName(output.bundleName); | |||
output.setBundleName(output.originalBundleName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a function to invoke like output.originalBundleName()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so with a get
method you don't need to actually call it, it handles that under the hood for you.
Bundle ReportChanges will increase total bundle size by 206 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will decrease total bundle size by 39.24kB (-0.68%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Description
We noticed that when running the plugins to analyze the plugins the bundle names were not being reset with Unbuild correctly. This resolves the issue, by reseting the bundle name when running.