Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sshin/rollup 4 #208

Closed
wants to merge 18 commits into from
Closed

Sshin/rollup 4 #208

wants to merge 18 commits into from

Conversation

suejung-sentry
Copy link
Contributor

Description

Code Example

Notable Changes

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@suejung-sentry suejung-sentry changed the base branch from main to sshin/chore/rollup-2 November 18, 2024 18:40
@suejung-sentry suejung-sentry changed the base branch from sshin/chore/rollup-2 to main November 18, 2024 18:40
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.08%. Comparing base (c3546ff) to head (ab50ee8).

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Plugin core 97.06% <ø> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 49.88% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Components Coverage Δ
Plugin core 97.06% <ø> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 49.88% <ø> (ø)

📢 Thoughts on this report? Let us know!

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 7.83kB (0.28%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/nextjs-webpack-plugin-esm* 1.11kB 753 bytes (-40.33%) ⬇️
@codecov/rollup-plugin-esm* 1.3kB 1.02kB (-43.95%) ⬇️
@codecov/webpack-plugin-cjs* 4.46kB 57 bytes (1.3%) ⬆️
@codecov/sveltekit-plugin-esm* 1.09kB 198 bytes (22.22%) ⬆️
@codecov/webpack-plugin-esm* 3.36kB 6 bytes (0.18%) ⬆️
@codecov/rollup-plugin-cjs-esm-esm-esm-esm 1.3kB 1.3kB (100%) ⬆️
@codecov/bundle-analyzer-cjs-esm 3.45kB 3.45kB (100%) ⬆️
@codecov/webpack-plugin-cjs-esm-esm 3.36kB 3.36kB (100%) ⬆️
@codecov/nuxt-plugin-cjs-esm 1.23kB 1.23kB (100%) ⬆️

ℹ️ *Bundle size includes cached data from a previous commit

Copy link

codecov bot commented Nov 18, 2024

Bundle Report

Changes will increase total bundle size by 148.95kB (2.57%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/sveltekit-plugin-esm* 1.09kB 198 bytes (22.22%) ⬆️
@codecov/webpack-plugin-cjs 4.46kB 57 bytes (1.3%) ⬆️
@codecov/webpack-plugin-esm* 3.36kB 6 bytes (0.18%) ⬆️
@codecov/bundle-analyzer-esm* 3.11kB 347 bytes (-10.05%) ⬇️
@codecov/sveltekit-plugin-cjs-esm-esm 891 bytes 891 bytes (100%) ⬆️
@codecov/vite-plugin-cjs-esm 2.32kB 2.32kB (100%) ⬆️
@codecov/remix-vite-plugin-cjs-esm 1.09kB 1.09kB (100%) ⬆️
@codecov/solidstart-plugin-cjs-esm-esm-esm 949 bytes 949 bytes (100%) ⬆️
@codecov/rollup-plugin-cjs-esm 2.32kB 2.32kB (100%) ⬆️
@codecov/webpack-plugin-cjs-esm-esm-esm-esm 3.36kB 3.36kB (100%) ⬆️
@codecov/bundler-plugin-core-cjs-esm-esm-esm 12.29kB 12.29kB (100%) ⬆️
@codecov/nextjs-webpack-plugin-cjs-esm 1.87kB 1.87kB (100%) ⬆️
@codecov/nuxt-plugin-cjs-esm-esm-esm 830 bytes 830 bytes (100%) ⬆️
@codecov/bundler-plugin-core-cjs-esm-esm 12.29kB 12.29kB (100%) ⬆️
@codecov/nuxt-plugin-cjs-esm-esm-esm-esm 830 bytes 830 bytes (100%) ⬆️
@codecov/nextjs-webpack-plugin-cjs-esm-esm-esm-esm 1.11kB 1.11kB (100%) ⬆️
@codecov/solidstart-plugin-cjs-esm-esm-esm-esm 949 bytes 949 bytes (100%) ⬆️
@codecov/vite-plugin-cjs-esm-esm-esm 1.24kB 1.24kB (100%) ⬆️
@codecov/bundle-analyzer-cjs-esm-esm-esm 3.11kB 3.11kB (100%) ⬆️
@codecov/nextjs-webpack-plugin-cjs-esm-esm-esm 1.11kB 1.11kB (100%) ⬆️
@codecov/bundler-plugin-core-cjs-esm 53.11kB 53.11kB (100%) ⬆️
@codecov/nuxt-plugin-cjs-esm-esm 830 bytes 830 bytes (100%) ⬆️
@codecov/bundle-analyzer-cjs-esm-esm 3.11kB 3.11kB (100%) ⬆️
@codecov/vite-plugin-cjs-esm-esm-esm-esm 1.24kB 1.24kB (100%) ⬆️
@codecov/webpack-plugin-cjs-esm-esm-esm 3.36kB 3.36kB (100%) ⬆️
@codecov/rollup-plugin-cjs-esm-esm-esm-esm 1.3kB 1.3kB (100%) ⬆️
@codecov/solidstart-plugin-cjs-esm-esm 949 bytes 949 bytes (100%) ⬆️
@codecov/rollup-plugin-cjs-esm-esm 1.3kB 1.3kB (100%) ⬆️
@codecov/sveltekit-plugin-cjs-esm-esm-esm-esm 891 bytes 891 bytes (100%) ⬆️
@codecov/nuxt-plugin-cjs-esm 1.23kB 1.23kB (100%) ⬆️
@codecov/remix-vite-plugin-cjs-esm-esm 957 bytes 957 bytes (100%) ⬆️
@codecov/sveltekit-plugin-cjs-esm 1.09kB 1.09kB (100%) ⬆️
@codecov/bundle-analyzer-cjs-esm 3.45kB 3.45kB (100%) ⬆️
@codecov/webpack-plugin-cjs-esm 3.36kB 3.36kB (100%) ⬆️
@codecov/remix-vite-plugin-cjs-esm-esm-esm 957 bytes 957 bytes (100%) ⬆️
@codecov/solidstart-plugin-cjs-esm 1.09kB 1.09kB (100%) ⬆️
@codecov/nextjs-webpack-plugin-cjs-esm-esm 1.11kB 1.11kB (100%) ⬆️
@codecov/remix-vite-plugin-cjs-esm-esm-esm-esm 957 bytes 957 bytes (100%) ⬆️
@codecov/webpack-plugin-cjs-esm-esm 3.36kB 3.36kB (100%) ⬆️
@codecov/sveltekit-plugin-cjs-esm-esm-esm 891 bytes 891 bytes (100%) ⬆️
@codecov/bundler-plugin-core-cjs-esm-esm-esm-esm 12.29kB 12.29kB (100%) ⬆️
@codecov/vite-plugin-cjs-esm-esm 1.24kB 1.24kB (100%) ⬆️
@codecov/bundle-analyzer-cjs-esm-esm-esm-esm 3.11kB 3.11kB (100%) ⬆️
@codecov/rollup-plugin-cjs-esm-esm-esm 1.3kB 1.3kB (100%) ⬆️

ℹ️ *Bundle size includes cached data from a previous commit

@suejung-sentry suejung-sentry deleted the sshin/rollup-4 branch November 18, 2024 20:11
@suejung-sentry
Copy link
Contributor Author

@codecov-ai-reviewer review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant