Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Setup test apps for upcoming snapshot tests #17

Merged
merged 12 commits into from
Dec 5, 2023

Conversation

nicholas-codecov
Copy link
Collaborator

Description

This PR adds in new test apps for the upcoming integration/snapshot tests that we will be introducing for a full e2e test experience for the three bundler plugins. As well as a few small tweaks all around for package.json, eslint, tsconfig, etc.

Notable Changes

  • Create rollup, vite, and webpack test apps for upcoming snapshot tests
  • Few tweaks to package.json files all around

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ba0d59) 86.06% compared to head (31b10e9) 86.06%.

Additional details and impacted files
Components Coverage Δ
Plugin core 96.39% <ø> (ø)
Rollup plugin 7.14% <ø> (ø)
Vite plugin 7.14% <ø> (ø)
Webpack plugin 9.52% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliatcodecov eliatcodecov self-requested a review December 5, 2023 14:48
Copy link
Collaborator

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure the test apps are importing an npm dependency of some kind? I think it's useful to check what that will look like in snapshots.

We can also just make new test-apps for those scenarios

@nicholas-codecov nicholas-codecov merged commit e224faf into main Dec 5, 2023
10 checks passed
@nicholas-codecov nicholas-codecov deleted the setup-test-apps-for-snapshot-tests branch December 5, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants