Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vuln] Update nuxt to 3.12.4 #162

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

Description

This fixes https://github.com/codecov/internal-issues/issues/665 and https://github.com/codecov/internal-issues/issues/664

Code Example

Notable Changes

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Components Coverage Δ
Plugin core 96.84% <ø> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 50.11% <ø> (ø)

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.15%. Comparing base (ec6b13a) to head (b86ad0c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Plugin core 96.84% <ø> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 50.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented Sep 3, 2024

Bundle Report

Changes will increase total bundle size by 424.92kB ⬆️

Bundle name Size Change
@codecov/rollup-plugin-cjs 2.82kB 2.82kB ⬆️
@codecov/rollup-plugin-esm 1.3kB 1.3kB ⬆️
@codecov/nuxt-plugin-cjs 1.41kB 1.41kB ⬆️
@codecov/solidstart-plugin-cjs 1.33kB 1.33kB ⬆️
@codecov/solidstart-plugin-esm 949 bytes 949 bytes ⬆️
@codecov/example-next-app-server-cjs 340.72kB 340.72kB ⬆️
@codecov/nextjs-webpack-plugin-esm 1.11kB 1.11kB ⬆️
@codecov/nuxt-plugin-esm 830 bytes 830 bytes ⬆️
@codecov/webpack-plugin-esm 3.36kB 3.36kB ⬆️
@codecov/remix-vite-plugin-cjs 1.32kB 1.32kB ⬆️
@codecov/sveltekit-plugin-esm 891 bytes 891 bytes ⬆️
@codecov/vite-plugin-cjs 2.8kB 2.8kB ⬆️
@codecov/remix-vite-plugin-esm 957 bytes 957 bytes ⬆️
@codecov/vite-plugin-esm 2.33kB 2.33kB ⬆️
@codecov/bundler-plugin-core-cjs 45.44kB 45.44kB ⬆️
@codecov/nextjs-webpack-plugin-cjs 2.11kB 2.11kB ⬆️
@codecov/bundler-plugin-core-esm 10.26kB 10.26kB ⬆️
@codecov/webpack-plugin-cjs 4.35kB 4.35kB ⬆️
@codecov/sveltekit-plugin-cjs 1.33kB 1.33kB ⬆️
@codecov/example-next-app-edge-server-array-push (removed) 354 bytes ⬇️
@codecov/example-next-15-app-edge-server-array-push (removed) 356 bytes ⬇️

Copy link

codecov bot commented Sep 3, 2024

Bundle Report

Changes will increase total bundle size by 13.11kB ⬆️

Bundle name Size Change
@codecov/rollup-plugin-esm 2.33kB 1.03kB ⬆️
@codecov/webpack-plugin-esm 3.36kB 42 bytes ⬆️
@codecov/example-nuxt-app-client-esm 242.59kB 5.33kB ⬆️
@codecov/example-sveltekit-app-client-esm 714.98kB 380 bytes ⬆️
@codecov/example-sveltekit-app-server-esm 974.84kB 269 bytes ⬆️
@codecov/example-nuxt-app-server-esm 353.86kB 6.06kB ⬆️

@@ -14,6 +14,7 @@ export default defineConfig({
},
},
plugins: [
//@ts-expect-error handle conflicting vite version types
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced with @nicholas-codecov. Types are not playing nice with version bumps.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this a bit more, since we're doing a minor version change of nuxt and sveltekit these should be minor as well

@rohitvinnakota-codecov rohitvinnakota-codecov merged commit be89828 into main Sep 4, 2024
52 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/update-nuxt-deps branch September 4, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants