-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta(changelog): Update package versions (beta) #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code review focuses on the changes related to package version updates and modifications in patch changes. Overall, the changes are consistent and clear. However, there's a small room for improvements on the code maintainability and readability side.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/bundler-plugin-core", | |||
"version": "0.0.1-beta.10", | |||
"version": "0.0.1-beta.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package version has been bumped up. Make sure to test thoroughly to ensure that this version of the software works as expected.
- dfb26db: Adjust asset type to contain gzipSize, add new function to collect gzip values | ||
- dfb26db: Set version from passed output arg, and collect gzip information in plugins | ||
- dfb26db: Update meta-framework plugins to collect version generated in output arg | ||
- Updated dependencies [dfb26db] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is good practice to give a strong description of what changes took place in different commits. This gives future developers a clearer insight into what specific updates occurred.
### Patch Changes | ||
|
||
- dfb26db: Adjust asset type to contain gzipSize, add new function to collect gzip values | ||
- dfb26db: Set version from passed output arg, and collect gzip information in plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, explanatory commit messages help in understanding the reasoning behind specific changes.
|
||
- dfb26db: Adjust asset type to contain gzipSize, add new function to collect gzip values | ||
- dfb26db: Set version from passed output arg, and collect gzip information in plugins | ||
- dfb26db: Update meta-framework plugins to collect version generated in output arg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A detailed description of changes should be given here for transparency for future developers. Providing more context about the changes contained under dfb26db will improve the code maintainability.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/nuxt-plugin", | |||
"version": "0.0.1-beta.10", | |||
"version": "0.0.1-beta.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take care to test this new version comprehensively to ensure there are no bugs or issues rising from the version update.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/remix-vite-plugin", | |||
"version": "0.0.1-beta.10", | |||
"version": "0.0.1-beta.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package version has been updated. It's important to test thoroughly to make sure everything still works as expected with the new version. If there are any breaking changes, they should be documented.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Bundle ReportChanges will increase total bundle size by 233 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 1.11kB ⬆️
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
main
is currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, runchangeset pre exit
onmain
.Releases
@codecov/[email protected]
Patch Changes
@codecov/[email protected]
Patch Changes
@codecov/[email protected]
Patch Changes
@codecov/[email protected]
Patch Changes
@codecov/[email protected]
Patch Changes
@codecov/[email protected]
Patch Changes
@codecov/[email protected]
Patch Changes