Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rebrand Remix plugin to include Vite #142

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

nicholas-codecov
Copy link
Collaborator

Description

This PR adjusts the name of the @codecov/remix-plugin package over to @codecov/remix-vite-plugin just so we are extremely explicit that we only support Remix projects that are using their Vite plugin.

Notable Changes

  • Adjust package name
  • Adjust dir names
  • Adjust export names
  • Adjust tests
  • Adjust CI
  • Adjust Changesets

@codecov-notifications
Copy link

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
packages/remix-vite-plugin/src/index.ts 0.00% 20 Missing ⚠️
Components Coverage Δ
Plugin core 97.69% <ø> (ø)
Rollup plugin 10.37% <ø> (ø)
Vite plugin 10.52% <ø> (ø)
Webpack plugin 26.04% <ø> (ø)

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 76.38%. Comparing base (a2e576f) to head (48d5a8d).

✅ All tests successful. No failed tests found.

Files Patch % Lines
packages/remix-vite-plugin/src/index.ts 0.00% 20 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
Plugin core 97.69% <ø> (ø)
Rollup plugin 10.37% <ø> (ø)
Vite plugin 10.52% <ø> (ø)
Webpack plugin 26.04% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented Jun 14, 2024

Bundle Report

Changes will increase total bundle size by 461 bytes ⬆️

Bundle name Size Change
@codecov/rollup-plugin-cjs 2.96kB 0 bytes
@codecov/sveltekit-plugin-esm 909 bytes 0 bytes
@codecov/example-webpack-app-array-push 71.19kB 0 bytes
@codecov/rollup-plugin-esm 1.32kB 0 bytes
@codecov/example-next-app-server-cjs 342.32kB 0 bytes
@codecov/webpack-plugin-cjs 3.59kB 0 bytes
@codecov/nuxt-plugin-esm 1.23kB 373 bytes ⬆️
@codecov/webpack-plugin-esm 1.44kB 0 bytes
@codecov/remix-vite-plugin-esm 975 bytes 975 bytes ⬆️
@codecov/example-vite-app-esm 150.61kB 0 bytes
@codecov/bundler-plugin-core-cjs 42.12kB 0 bytes
@codecov/example-next-app-client-array-push 907.85kB 0 bytes
@codecov/remix-vite-plugin-cjs 1.31kB 1.31kB ⬆️
@codecov/vite-plugin-cjs 2.96kB 0 bytes
@codecov/vite-plugin-esm 1.26kB 0 bytes
@codecov/bundler-plugin-core-esm 7.32kB 0 bytes
@codecov/sveltekit-plugin-cjs 1.32kB 0 bytes
@codecov/nuxt-plugin-cjs 1.4kB 0 bytes
@codecov/example-rollup-app-iife 95.45kB 0 bytes
@codecov/example-next-app-edge-server-array-push 354 bytes 0 bytes
@codecov/remix-plugin-cjs (removed) 1.3kB ⬇️
@codecov/remix-plugin-esm (removed) 904 bytes ⬇️

Copy link

codecov bot commented Jun 14, 2024

Bundle Report

Changes will increase total bundle size by 88 bytes ⬆️

Bundle name Size Change
@codecov/rollup-plugin-cjs 2.96kB 0 bytes
@codecov/rollup-plugin-esm 1.32kB 0 bytes
@codecov/remix-vite-plugin-cjs 1.31kB 1.31kB ⬆️
@codecov/remix-vite-plugin-esm 975 bytes 975 bytes ⬆️
@codecov/sveltekit-plugin-cjs 1.32kB 0 bytes
@codecov/sveltekit-plugin-esm 909 bytes 0 bytes
@codecov/example-sveltekit-app-client-esm 714.6kB 0 bytes
@codecov/example-next-app-client-array-push 907.85kB 0 bytes
@codecov/example-remix-app-client-esm 252.12kB 0 bytes
@codecov/example-vite-app-esm 150.61kB 0 bytes
@codecov/example-remix-app-server-esm 12.55kB 0 bytes
@codecov/example-sveltekit-app-server-esm 974.58kB 0 bytes
@codecov/vite-plugin-cjs 2.96kB 0 bytes
@codecov/bundler-plugin-core-cjs 42.12kB 0 bytes
@codecov/webpack-plugin-cjs 3.59kB 0 bytes
@codecov/nuxt-plugin-cjs 1.4kB 0 bytes
@codecov/bundler-plugin-core-esm 7.32kB 0 bytes
@codecov/vite-plugin-esm 1.26kB 0 bytes
@codecov/webpack-plugin-esm 1.44kB 0 bytes
@codecov/nuxt-plugin-esm 855 bytes 0 bytes
@codecov/example-rollup-app-iife 95.45kB 0 bytes
@codecov/example-nuxt-app-client-esm 237.66kB 0 bytes
@codecov/example-next-app-server-cjs 342.32kB 0 bytes
@codecov/example-nuxt-app-server-esm 347.95kB 0 bytes
@codecov/example-webpack-app-array-push 71.19kB 0 bytes
@codecov/example-next-app-edge-server-array-push 354 bytes 0 bytes
@codecov/remix-plugin-esm (removed) 904 bytes ⬇️
@codecov/remix-plugin-cjs (removed) 1.3kB ⬇️

@nicholas-codecov nicholas-codecov merged commit baf70ba into main Jun 14, 2024
39 of 41 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-rename-remix-plugin-to-include-vite branch June 14, 2024 16:00
@nicholas-codecov nicholas-codecov changed the title fix: Rebranch Remix plugin to include Vite fix: Rebrand Remix plugin to include Vite Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants