feat: Overhaul popup menu and provider management #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is primarily meant to fix a bug where github enterprise URLs would not actually work due to 'github' being the hardcoded provider on API requests. While I was in here though I took it as a chance to rewrite the popup menu to address some other issues.
Goals for the new popup:
I think this PR was successful in achieving each of these goals! Have approved and iterated on design with input from Adalene.
Am currently testing everything actually works on a real Github enterprise instance and will not merge before confirming.
This is what the final result looks like:
Here's what it currently looks like for comparison: