Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shared to pull in migrations #1096

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Update shared to pull in migrations #1096

merged 1 commit into from
Jan 15, 2025

Conversation

Swatinem
Copy link
Contributor

This primarily pulls in codecov/shared#442 to remove some unused indices from the production table, and align the migration state with the reality of the DB.

@Swatinem Swatinem self-assigned this Jan 15, 2025
@Swatinem Swatinem requested a review from a team January 15, 2025 08:49
Copy link
Contributor

This PR includes changes to shared. Please review them here: codecov/shared@de4b37b...07b39b2

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (fa372bf) to head (bb50f45).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1096   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         829      829           
  Lines       19384    19384           
=======================================
  Hits        18627    18627           
  Misses        757      757           
Flag Coverage Δ
unit 96.00% <ø> (ø)
unit-latest-uploader 96.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@Swatinem Swatinem added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@Swatinem Swatinem added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 0bcf77b Jan 15, 2025
19 checks passed
@Swatinem Swatinem deleted the swatinem/update-shared branch January 15, 2025 10:08
Swatinem added a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants