Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 2.5 support, using ~2.4 in composer.json #37

Closed
wants to merge 2 commits into from

Conversation

joschi127
Copy link
Contributor

Alternative PR for #29, for closing issue #26

Without this it is currently broken and I cannot successfully run the tests with Symfony 2.5. Fails on doctrine:database:create.
@joschi127
Copy link
Contributor Author

The tests do also fail for me locally when not using "prefer-stable": true in composer.json.

So I just pushed an update for the PR which adds the prefer-stable option. With this I can successfully run all tests locally.

(However: for me it failed during doctrine:database:create and this seems to be another issue than the one that happened in Scrutinizer. But let's give it a try and see if Scritinizer passes. And of course: I do not know if you want to have the prefer-stable option set.)

@joschi127
Copy link
Contributor Author

Ok, works this way :-) Just decide yourself if you want to merge it and if you want to use the prefer-stable option in composer.json.

@reecefowell
Copy link
Member

Satisfied by PR #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants