fix newsllatter subscription

code4romania · Nov 7, 2024 · 05ddcc1 · 05ddcc1
1 parent f7ea946
commit 05ddcc1
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/app/Services/NewsletterService.php b/app/Services/NewsletterService.php
@@ -11,10 +11,14 @@ class NewsletterService
 {
     public static function subscribe(string $email, ?string $name = null)
     {
-        $mergeFields = [
-            'MERGE1' => $name,
-        ];
+        $mergeFields = [];
+        if (filled($name))
+        {
+            $mergeFields = [
+                'MERGE1' => $name,
+            ];
 
+        }
         $response = rescue(
             fn () => Newsletter::subscribe($email, $mergeFields),
             false
@@ -24,11 +28,11 @@ public static function subscribe(string $email, ?string $name = null)
             Log::error('Failed to subscribe user to newsletter', [
                 'email' => $email,
                 'response' => $response,
+                'error' => Newsletter::getApi()->getLastError(),
             ]);
 
             // TODO: check if email registered as user
-            // and assign subscriber badge if the
-            // user doesn't already have one.
+
         }
 
         return $response;