handle missing asset type

code4me · Jan 15, 2024 · c47e5a6 · c47e5a6
1 parent 1bd2ea3
commit c47e5a6
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 1 deletion.
diff --git a/lansweeper/aws/integration-lambda/lansweeper_helper.js b/lansweeper/aws/integration-lambda/lansweeper_helper.js
@@ -127,7 +127,7 @@ class LansweeperHelper {
 
   getProductCategory(asset) {
     return this.getByReferenceOrAdd(this.categories,
-                                    asset.assetBasicInfo.type,
+                                    asset.assetBasicInfo.type || 'Unknown',
                                     (reference, assetType) => {
                                       return {
                                         name: assetType,

diff --git a/lansweeper/aws/integration-lambda/tests/lansweeper_helper.test.js b/lansweeper/aws/integration-lambda/tests/lansweeper_helper.test.js
@@ -33,7 +33,44 @@ describe('toReference', () => {
   });
 });
 
+describe('getProductCategory', () => {
+  it('handles undefined type', () => {
+    const asset = {
+      assetCustom: {},
+      assetBasicInfo: {name: 'Smart TV'},
+    };
+    const productCategory = helper.getProductCategory(asset);
+
+    expect(productCategory.reference).toEqual('unknown');
+    expect(productCategory.name).toEqual('Unknown');
+  });
+
+  it('handles type', () => {
+    const asset = {
+      assetCustom: {},
+      assetBasicInfo: {name: 'Smart TV', type: 'Tv'},
+    };
+    const productCategory = helper.getProductCategory(asset);
+
+    expect(productCategory.reference).toEqual('tv');
+    expect(productCategory.name).toEqual('Tv');
+  });
+});
+
+
 describe('getProduct', () => {
+  it('handles undefined type', () => {
+    const asset = {
+      assetCustom: {},
+      assetBasicInfo: {name: 'Smart TV'},
+    };
+    const product = helper.getProduct(asset);
+
+    expect(product.reference).toEqual('unknown_unknown_unknown');
+    expect(product.model).toEqual('Unknown');
+    expect(product.brand).toEqual('Unknown');
+  });
+
   it('handles undefined model and brand', () => {
     const asset = {
       assetCustom: {},