-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Workflow Fix #38
Conversation
Signed-off-by: Sahil Suman <[email protected]>
Signed-off-by: Sahil Suman <[email protected]>
@sahilsuman933 is attempting to deploy a commit to the My Team Team on Vercel. A member of the Team first needs to authorize it. |
Please review this PR @hkirat and share me your feedback |
This is not true, push will run the workflow on every push you make. This can lead to unecessary actions time usages because sometimes you don;t need to run it. The issue probably is with
corrected should be
Also there are a lot of file changes. I think the only thing needed to be changed is prettier config file. |
Signed-off-by: Sahil Suman <[email protected]>
I've reverted the trigger to 'on pull_request'. You can see the preview here: sahilsuman933/cms#3 As I noted in my third point, the additional changes are a result of formatting the existing codebase, as it was previously unformatted. // @siinghd |
I see a lot of conflicts, can u get rid of those? |
Yes, there are many merge conflicts. I believe it would be more efficient to create a new pull request with changes only in lint.yml, .prettierrc, and .eslintrc. Once that part is merged, I will create another pull request to format the existing code. |
fixes #19 #23
This PR addresses three issues:
push
trigger instead ofpull_request
.a. It changes single quotes to double quotes.
b. The eslint indentation check is removed as prettier and eslint indent do not work together due to differing indentation styles. Reference: https://stackoverflow.com/questions/56337176/prettier-and-eslint-indents-not-working-together
c. Made semicolon necessary.
To review whether this workflow is functioning correctly, you can check here: https://github.com/sahilsuman933/cms/actions/runs/7750601270/job/21137093903 and sahilsuman933/cms#2