Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Workflow Fix #38

Closed
wants to merge 3 commits into from

Conversation

sahilsuman933
Copy link
Contributor

@sahilsuman933 sahilsuman933 commented Feb 2, 2024

fixes #19 #23

This PR addresses three issues:

  1. The requirement is to run the workflow on each pull request made to this repository. To achieve this, we need to use the push trigger instead of pull_request.
  2. It resolves several conflicts between eslint and prettier.
    a. It changes single quotes to double quotes.
    b. The eslint indentation check is removed as prettier and eslint indent do not work together due to differing indentation styles. Reference: https://stackoverflow.com/questions/56337176/prettier-and-eslint-indents-not-working-together
    c. Made semicolon necessary.
  3. Format the existing codebase

To review whether this workflow is functioning correctly, you can check here: https://github.com/sahilsuman933/cms/actions/runs/7750601270/job/21137093903 and sahilsuman933/cms#2

Copy link

vercel bot commented Feb 2, 2024

@sahilsuman933 is attempting to deploy a commit to the My Team Team on Vercel.

A member of the Team first needs to authorize it.

@sahilsuman933 sahilsuman933 changed the title [Chore] Formatting Codebase [Bugfix] Workflow Fix Feb 2, 2024
@sahilsuman933
Copy link
Contributor Author

Please review this PR @hkirat and share me your feedback

@siinghd
Copy link
Collaborator

siinghd commented Feb 2, 2024

fixes #19 #23

This PR addresses three issues:

  1. The requirement is to run the workflow on each pull request made to this repository. To achieve this, we need to use the push trigger instead of pull_request.

This is not true, push will run the workflow on every push you make. This can lead to unecessary actions time usages because sometimes you don;t need to run it.

The issue probably is with

pull_request:
    branches:
      - '**'

corrected should be

pull_request:
    branches:
      - '*'

Also there are a lot of file changes. I think the only thing needed to be changed is prettier config file.
@sahilsuman933

@sahilsuman933
Copy link
Contributor Author

sahilsuman933 commented Feb 2, 2024

I've reverted the trigger to 'on pull_request'. You can see the preview here: sahilsuman933/cms#3

As I noted in my third point, the additional changes are a result of formatting the existing codebase, as it was previously unformatted.

// @siinghd

@hkirat
Copy link
Contributor

hkirat commented Feb 3, 2024

I see a lot of conflicts, can u get rid of those?

@sahilsuman933
Copy link
Contributor Author

Yes, there are many merge conflicts. I believe it would be more efficient to create a new pull request with changes only in lint.yml, .prettierrc, and .eslintrc. Once that part is merged, I will create another pull request to format the existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint workflow doesnt seem to be working
3 participants