feat: to navigate through videos by prev and next video button #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adding it to things to review |
|
hey @devsargam |
|
This is great but I need to review for all edge cases |
devsargam
requested changes
Oct 20, 2024
src/components/VideoPlayer2.tsx
Outdated
|
|
||
| const root = createRoot(pipButtonContainer.el()); | ||
| root.render(<PipButton />); | ||
| root.render(<span className="material-symbols-outlined">picture_in_picture_alt</span>); |
There was a problem hiding this comment.
Can you please revert the PipButton logic?
There was a problem hiding this comment.
@devsargam
there was some error on prev Pip button logic, and also some error on my Pip Button logic.
i have fixed all the errors, please review it.
|
Sorry this looks really good but considering this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Features:
Limitations
added.next.and.prev.button.mp4
Resolves #1166
Checklist before requesting a review