Fix SteamLibraryLoaderGdx on macOS #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behind the scenes, the libgdx loader extracts libsteam_api.dylib and libsteamworks4j.dylib into separate directories based on the CRC checksum of their contents. Unfortunately, libsteam_api.dylib has an install name of @loader_path/libsteam_api.dylib. When loading libsteamworks4j.dylib it expects libsteam_api.dylib to have been in the same directory. This patch hardcodes the result of `crc()` to `00000000`. As a result, both libraries will be extracted inside `<libgdx-path>/00000000/` and libsteamworks4j.dylib loads successfully.
|
Closing #130 as this solves the problem it tried to workaround. |
|
Tested on Windows, Intel Mac, and Steam Deck |
|
@noblemaster Could you try this out for me on an apple silicon mac? I still don't have access to one sadly, but I suspect this will work for you since the previous loader did. |
|
Yes, it works on M2! Just merge it when you are ready. 😄 |
noblemaster
approved these changes
Sep 29, 2023
Awesome! Thanks. |
|
@code-disaster Any thoughts? |
|
This seems to be the solution I need. How can I test this as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behind the scenes, the libgdx loader extracts
libsteam_api.dylibandlibsteamworks4j.dylibinto separate directories based on the CRC checksum of their contents.Unfortunately,
libsteam_api.dylibhas an install name of@loader_path/libsteam_api.dylib.When loading
libsteamworks4j.dylibit expectslibsteam_api.dylibto be in the same directory.This patch hardcodes the result of
crc()to00000000. As a result, both libraries will be extracted inside<libgdx-path>/00000000/and libsteamworks4j.dylib loads successfully.Fixes #117