TASK: Allow sizes and multiplier for container #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justusmoroni
requested changes
Apr 5, 2024
extcode
pushed a commit
that referenced
this pull request
Apr 5, 2024
Instead of iterating over the rootline, the rootline is set up so that every child knows the parent. If the child itself has no size configuration, the calculated multiplier is passed on to the parent for calculation. In this way, the complete calculation is stored out of the rootline class. New classes had to be introduced for the columns of the containers and the columns of the backend layout. A corresponding element is then added to the rootline for these columns. Related: #26
extcode
force-pushed
the
task/allow_sizes_and_multiplier_for_container
branch
2 times, most recently
from
5c93a02 to
fc27504
Compare
Instead of iterating over the rootline, the rootline is set up so that every child knows the parent. If the child itself has no size configuration, the calculated multiplier is passed on to the parent for calculation. In this way, the complete calculation is stored out of the rootline class. New classes had to be introduced for the columns of the containers and the columns of the backend layout. A corresponding element is then added to the rootline for these columns. Related: #26
DanielSiepmann
force-pushed
the
task/allow_sizes_and_multiplier_for_container
branch
from
774f08f to
616a9f2
Compare
DanielSiepmann
approved these changes
Apr 11, 2024
extcode
requested review from
justusmoroni
and removed request for
justusmoroni
justusmoroni
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #22