feat: Detect containers by searching the registry #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extcode
previously approved these changes
Apr 3, 2024
Before we checked if a CType contained a specific string to check if it is a container. This was open to false positives if a normal content element also contained this string. We now check the proper place to detect if a CType is registered as a container. Related: #6
justusmoroni
force-pushed
the
feature/6-container-detection
branch
from
f8b29e5 to
ead5357
Compare
extcode
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we checked if a CType contained a specific
string to check if it is a container. This was
open to false positives if a normal content
element also contained this string.
We now check the proper place to detect if a CType is registered as a container.
Related: #6