CLEANUP: Remove extra variable for readConfigurationByPath

codappix · Apr 5, 2024 · 3935047 · 3935047
1 parent 491c101
commit 3935047
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 18 deletions.
diff --git a/Classes/Sizes/Container.php b/Classes/Sizes/Container.php
@@ -35,7 +35,13 @@ public function __construct(array $data)
     {
         parent::__construct($data);
 
-        $this->readConfiguration();
+        $this->scalingConfiguration = $this->readConfigurationByPath(
+            implode('.', [
+                'container',
+                $this->contentType,
+            ])
+        );
+
         $this->determineColumns();
     }
 
@@ -59,16 +65,6 @@ public function getActiveColumn(): Column
         return $this->activeColumn;
     }
 
-    public function readConfiguration(): void
-    {
-        $configurationPath = implode('.', [
-            'container',
-            $this->contentType,
-        ]);
-
-        $this->scalingConfiguration = $this->readConfigurationByPath($configurationPath);
-    }
-
     private function determineColumns(): void
     {
         $sizesPath = implode('.', [

diff --git a/Classes/Sizes/ContentElement.php b/Classes/Sizes/ContentElement.php
@@ -31,12 +31,12 @@ public function __construct(
     ) {
         parent::__construct($data);
 
-        $configurationPath = implode('.', [
-            'contentelements',
-            $this->contentType,
-            $this->fieldName,
-        ]);
-
-        $this->scalingConfiguration = $this->readConfigurationByPath($configurationPath);
+        $this->scalingConfiguration = $this->readConfigurationByPath(
+            implode('.', [
+                'contentelements',
+                $this->contentType,
+                $this->fieldName,
+            ])
+        );
     }
 }