-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enforce a lower case letter at the beginning of the summary content #2
base: main
Are you sure you want to change the base?
fix: enforce a lower case letter at the beginning of the summary content #2
Conversation
ea0f755
to
f9a6fc6
Compare
✔️ f9a6fc6 - Conventional commits check succeeded. |
Hey @aeyoll I am a bit confused, is this mentioned in the conventional commit spec ? |
Hey @oknozor, I understand that it can be out of scope for this project if its not described in the spec. However, maybe it could be a configurable option in the parser? (My goal behind all this is to ditch Thanks a lot |
Hey @aeyoll, Thanks for the suggestion but I cannot merge this as is.
This is the way to go. Ideally we could expose a parser builder which would allow to add more parsing options without breaking the public API again. Also adding the lowercase rule only is not ideal. I'd rather have the angular commit spec implemented all at once. Regarding the implementation I think the pest grammar file for the conventional commit spec should be left untouched. Once we have this in the parser I would be trivial to add an angular commit flag/config to the cli. Let me know if you want to work on it. |
Thanks for the feedback, I totally understand that you can't merge it.
The Angular spec is actually not that different from conventional commit spec, I think it only adds this lower case rule, plus a max length of 100 of every line of the message.
It would be the easiest way, but it adds another layer of verification on top of pest, I'm not sure if it's the most elegant solution. We could have multiple grammar files, but they would have a lot of similarities, which is not ideal either. Too bad pest doesn't allow to share rules between multiple grammars. |
No description provided.