Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui-components] Replace enzyme with react-testing-library #49

Open
laurenbarker opened this issue May 6, 2020 · 2 comments
Open

[ui-components] Replace enzyme with react-testing-library #49

laurenbarker opened this issue May 6, 2020 · 2 comments
Labels
🔩 tools Build system and infrastructure tasks and bugs

Comments

@laurenbarker
Copy link
Collaborator

What

Replace enzyme with react-testing-library for tests in ui-components.

Why

We have been piloting React Testing Library in Console and have had a very positive experience. It encourages good test practices and is a lot simpler to use than enzyme.
@laurenbarker
Copy link
Collaborator Author

@j-low what do you think of switching to RTL for ui-components?

@laurenbarker laurenbarker mentioned this issue May 6, 2020
Merged
3 tasks
@nathanstilwell nathanstilwell added the 🔩 tools Build system and infrastructure tasks and bugs label May 28, 2020
This was referenced Jul 1, 2020
Closed
Closed
Closed
Closed
Open
Open
@koorosh koorosh mentioned this issue Jul 17, 2020
Closed
@tharun208
Copy link
Contributor

tharun208 commented Feb 28, 2021 •
edited
Loading

@laurenbarker, I refactored the Avatar component tests using RTL #227. And refactoring other components unit tests will come as a separate pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔩 tools Build system and infrastructure tasks and bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nathanstilwell @laurenbarker @tharun208