ui: use admin-ui-components repo for Empty component … #51425
Conversation
|
This change is |
dhartunian
force-pushed
the
davidh-use-admin-ui-components-repo
branch
from
ffb6ef9 to
ae109fd
Compare
This component is no longer used as part of the `SortableTable`. We always link to a detail page instead of showing a "drawer" view for a table row. Release note: None
dhartunian
force-pushed
the
davidh-use-admin-ui-components-repo
branch
from
ae109fd to
957aa8d
Compare
There was a problem hiding this comment.
Everything looks great! But one test uses CSS selectors which still rely on styles that were extracted
with Empty component. Probably it fails because class names are hashed and we cannot rely on
them anymore.
pkg/ui/src/views/statements/diagnostics/diagnosticsView.spec.tsx LINE 56
There is an example of the selector which doesn't; rely on class names.
const activateButtonComponent = wrapper.findWhere(p => p.type() === "button" && p.text() === "Activate").first();
|
@koorosh what do you think of switching to |
We are transitioning the `Empty` component dependency to the `admin-ui-components` repo. In the long run, all components shared between Admin UI and CockroachCloud will be extracted in this manner. Depends on cockroachdb/yarn-vendored#24 Resolves cockroachdb#51382 Release note: None
dhartunian
force-pushed
the
davidh-use-admin-ui-components-repo
branch
from
957aa8d to
15232be
Compare
|
🎉 All dependencies have been resolved ! |
It's reasonable to me. Let's switch to it! As I see, it is supposed to be the default testing tool for UI projects (cockroachdb/ui#49) |
|
sweet, I'll give it a shot today! |
We are transitioning the
Emptycomponent dependency to theadmin-ui-componentsrepo. In the long run, all componentsshared between Admin UI and CockroachCloud will be extracted
in this manner.
Also removed an unused
Drawercomponent that was a candidatefor extraction.
Depends on cockroachdb/yarn-vendored#24
Resolves #51382