ansible: Fix sync-secrets playbook to not clobber s3-keys alias symlinks #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the workflows don't start, I just try a force-push. |
martinpitt
force-pushed
the
s3-image-key
branch
from
b4b70e8 to
8dcb695
Compare
The psi/image-cache playbook installs the s3-keys/ symlink for the local S3 mirror on rhos-01-1. But sync-secrets clobbers that (as it always removes the entire existing secrets dir before re-syncing it). Fix this by factoring out the symlink creation into a nwe "local-s3-alias" role and calling it from both places.
martinpitt
force-pushed
the
s3-image-key
branch
from
8dcb695 to
357ce16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The psi/image-cache playbook installs the s3-keys/ symlink for the local S3 mirror on rhos-01-1. But sync-secrets clobbers that (as it always removes the entire existing secrets dir before re-syncing it).
Fix this by factoring out the symlink creation into a nwe "local-s3-alias" role and calling it from both places.
I tested this by first removing the existing symlink /var/lib/cockpit-secrets/tasks/s3-keys/10.0.203.194, then running
which installed it everywhere. Afterwards I ran
(i.e. the step which previously removed the symlink), and confirmed that it installed it correctly. In a tasks container I can now do
(which previously failed with "no such key", see pilot board)