tasks: Speed up test_pr() #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonkarlitskaya
previously approved these changes
Mar 18, 2024
tasks/run-local.sh
Outdated
| @@ -435,7 +435,7 @@ test_pr() { | |||
|
|
|||
| # run the main loop in the background; we could do this with a single run-queue invocation, | |||
| # but we want to test the cockpit-tasks script | |||
| podman exec -i cockpituous-tasks cockpit-tasks & | |||
| podman exec -i --env=SLUMBER=5 cockpituous-tasks cockpit-tasks & | |||
The `[ -t 0 ]` check in `cockpit-tasks` doesn't do anything any more, as the integration tests now run that script with `podman exec`, without an attached tty. This is also a bit awkward for the upcoming pytest rewrite, so replace it with an environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
[ -t 0 ]check incockpit-tasksdoesn't do anything any more, as the integration tests now run that script withpodman exec, without an attached tty. This is also a bit awkward for the upcoming pytest rewrite, so replace it with an environment variable.