Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: build a multi-arch tasks container #603

Merged
merged 1 commit into from
Mar 15, 2024
Merged

workflows: build a multi-arch tasks container #603

merged 1 commit into from
Mar 15, 2024

Conversation

allisonkarlitskaya
Copy link
Member

Build a tasks container for arm64 in addition to amd64.

We do this by splitting the build process into multiple jobs. For the arm one, we make use of the arm runners from BuildJet. At the end, we write the manifest and upload that with the "public" tag name.

I kicked off a workflow run, which produced the 2024-03-15 tag on quay:
image

I'm taking that for a spin now in cockpit-project/starter-kit#812

@allisonkarlitskaya allisonkarlitskaya marked this pull request as ready for review March 15, 2024 10:58
@allisonkarlitskaya
Copy link
Member Author

Note: this doesn't push a :latest tag anymore.

@allisonkarlitskaya allisonkarlitskaya force-pushed the buildjet branch 2 times, most recently from 67449b2 to 2a006cb Compare March 15, 2024 11:53
@allisonkarlitskaya allisonkarlitskaya force-pushed the buildjet branch 2 times, most recently from a458141 to 8f3d245 Compare March 15, 2024 12:41
@allisonkarlitskaya
Copy link
Member Author

Out of all of the things that I thought might be difficult, I didn't imagine that it would be getting the :latest tag pushed.

Anyway — this is working, and we now have a 2024-03-15 and corresponding latest tag on quay, with the "temp" tags neatly tucked away in the cockpit/tasks-tmp repository.

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for figuring out all the details!

I'm a bit concerned about the integration test failure -- although it's not quite clear what this has to do with setting an empty LOG_MATCH. As a first thing, perhaps you could do a no-change force-push to run them again? (We can't just retry as the "unit-tests" context already exists).

.github/workflows/build-tasks.yml Show resolved Hide resolved
.github/workflows/build-tasks.yml Show resolved Hide resolved
Build a tasks container for arm64 in addition to amd64.

We do this by splitting the build process into multiple jobs.  For the
arm one, we make use of the arm runners from BuildJet.  At the end, we
write the manifest and upload that with the "public" tag name.

Remove the local infrastructure and rules for pushing the container;
it's not so easy anymore.
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✈️

@martinpitt martinpitt merged commit 6f813b7 into main Mar 15, 2024
3 checks passed
@martinpitt martinpitt deleted the buildjet branch March 15, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants