eslint: Enable "semi" rule #9736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
approved these changes
Jul 25, 2018
martinpitt
reviewed
Jul 25, 2018
pkg/apps/application-list.jsx
Outdated
| @@ -69,7 +69,7 @@ class ApplicationRow extends React.Component { | |||
| {comp.summary} | |||
| <div className="alert alert-danger alert-dismissable"> | |||
| <button className="close" | |||
| onClick={left_click(() => { this.setState({ error: null }) })}> | |||
| onClick={left_click(() => { this.setState({ error: null }); })}> | |||
There was a problem hiding this comment.
IMHO this is a bit over the top. I think this should rather drop the unnecessary { } and the semicolon for a single-line function call. I. e. () => this.setState(...).
martinpitt
requested changes
Jul 25, 2018
pkg/storaged/storage-controls.jsx
Outdated
| @@ -160,7 +160,7 @@ var StorageBlockNavLink = React.createClass({ | |||
| var parts = utils.get_block_link_parts(client, block.path); | |||
|
|
|||
| var link = ( | |||
| <a role="link" tabIndex="0" onClick={() => { cockpit.location.go(parts.location) }}> | |||
| <a role="link" tabIndex="0" onClick={() => { cockpit.location.go(parts.location); }}> | |||
pkg/storaged/storage-controls.jsx
Outdated
| @@ -185,7 +185,7 @@ class StorageOnOff extends React.Component { | |||
| var promise = self.props.onChange(val); | |||
| if (promise) { | |||
| promise.always(function() { | |||
| self.setState({ promise: null }) | |||
| self.setState({ promise: null }); | |||
| }); | |||
There was a problem hiding this comment.
and another one; also, function() { → () =>
atiratree
force-pushed
the
eslint-semi
branch
2 times, most recently
from
b7b67ce to
a3b93cc
Compare
I guess that is a bit too much. Added |
martinpitt
requested changes
Jul 26, 2018
- fix semicolons in all files
|
You are right, sorry I forgot to test it. Added corresponding jshint rule. |
martinpitt
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after the discussion with @mareklibra in #9466, we concluded it could be useful to have eslint rule for that