cockpit-components-dialog: React-related fixes #9341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dialog component requires title, body and footer props. The `show_modal_dialog` recently does not provide that for initial rendering, while injecting it later. This shall be fixed in a follow-up, preferably via replacing recent dialog by patternfly-react's ModalDialog component. This patch is part of preparation to switch from react-lite to React v16.4. This is hot-fix not changing semantics but avoiding React's verification.
44 tasks
The passed error message of a failing action is converted via `toString()`. This patch is part of preparation to switch from react-lite to React. The react-lite did this apparently on its own, React is failing here.
martinpitt
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9263 PR-split, see individual commits for more info.