lib: Support headers with SimpleSelect #21480
Conversation
| <SelectOption key={option.key} | ||
| isDisabled | ||
| className="ct-select-header"> | ||
| {option.content} | ||
| </SelectOption> |
There was a problem hiding this comment.
These 5 added lines are not executed by any test.
|
I start to think we should just use SelectOption et al with SimpleSelect instead of the extra indirection via the In my defense, I just went with the template offered by PatternFly without questioning it... |
There was a problem hiding this comment.
Putting SelectOptions into selects and such sounds good, as long as it's consistent (wrt. TypeaheadSelect as well). I'll let you decide if you want to go ahead with this PR (it looks nice, and doesn't really make the situation worse) to unblock the c-machines porting, or clean this up with SelectOption.
Thanks!
Needed to replace the deprecated select in cockpit-machines.