workflows: Allow urls-check to write issues #20166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit bc7e2bf was wrong: This workflow only doesn't need any permissions if all URLs are valid. But if not, then it wants to update/create an issue to notify us about that.
martinpitt
added
the
no-test
|
The manual run against this branch, and it passed again. It filed #20167 |
martinpitt
added
the
.github-changes
This might tell us what's wrong about that dmtf.org URL when running in GitHub (issue #20167).
github-actions
bot
removed
the
.github-changes
|
#20167 is bogus. I added another commit here to get some more data, and triggered another run |
|
OK, that must have been a transient network issue then .. the last check was ok, see #20168. To test the second commit, I deliberately damaged that URL in the source ( |
martinpitt
added
the
.github-changes
martinpitt
commented
Mar 13, 2024
| failed.append(url) | ||
| except urllib.error.URLError: | ||
| failed.append(url) | ||
| failed.append(f"{url} : {resp.getcode()} {resp.reason}") |
There was a problem hiding this comment.
As this looks a bit unusual/asymmetric, I tested this code path as well, by changing the 400 to 200, and then got:
Checked 177 URLs out of which 1 is/are invalid:
https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf: 200 OK
allisonkarlitskaya
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit bc7e2bf was wrong: This workflow only doesn't need any permissions if all URLs are valid. But if not, then it wants to update/create an issue to notify us about that.
Fixes this failure which started to happen 3 weeks ago.