bridge: accept null for host/group on kill
#20162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cleaned up our act in the Python bridge about never sending null for 'host' or 'group', by ensuring that we directly forward messages. We might still get these `null` values from outside, though. Just accept `null` as a valid value for these fields. It's the default value anyway. https://bugzilla.redhat.com/show_bug.cgi?id=2267376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cleaned up our act in the Python bridge about never sending null for 'host' or 'group', by ensuring that we directly forward messages. We might still get these
nullvalues from outside, though.Just accept
nullas a valid value for these fields. It's the default value anyway.https://bugzilla.redhat.com/show_bug.cgi?id=2267376