Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add fake default route to work around podman 5 regression #20153

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

martinpitt
Copy link
Member

podman 5 regressed user containers if there is no default route [1].
While that is being sorted out, add a fake interface with a default
route for our offline tests, to unbreak upstream podman PRs testing.

Same hack as in cockpit-project/cockpit-podman@cecb2cc6e8f2

[1] containers/podman#21896


See this failure in cockpit-project/bots#6050

I trigger a fedora-40/other@bots#6050 run, but due to a bug in our new infra it will be reported as "fedora-40" (see pilot board).

podman 5 regressed user containers if there is no default route [1].
While that is being sorted out, add a fake interface with a default
route for our offline tests, to unbreak upstream podman PRs testing.

Same hack as in cockpit-project/cockpit-podman@cecb2cc6e8f2

[1] containers/podman#21896
@jelly
Copy link
Member

jelly commented Mar 11, 2024

Strange, there is an unrelated mypy issue here:

not ok 7 /static-code/test-mypy
# src/cockpit/transports.py:405: error: Argument 2 to "add_child_handler" of "AbstractChildWatcher" has incompatible type "Callable[[int, int], None]"; expected "Callable[[], object]"  [arg-type]
# src/cockpit/transports.py:405: error: Argument 2 to "add_child_handler" of "AbstractChildWatcher" has incompatible type "Callable[[int, int], None]"; expected "Callable[[], object]"  [arg-type]

@martinpitt
Copy link
Member Author

@jelly yes, mypy "spontaneously" broke as the "tox" test does not pin versions. It's also on the pilot board. We need to move that into the tasks container and update it in a controlled way. It's very similar to new ruff versions, which I fixed last week (PR #20149)

@martinpitt martinpitt merged commit 3286bcb into cockpit-project:main Mar 11, 2024
73 of 74 checks passed
@martinpitt martinpitt deleted the pasta-hack branch March 11, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants