logs: Do not use duplicate object to keep state #20137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source of the truth should be `currentIdentifiers` as defined in `logs.jsx`. `logsJournal.jsx` had separate object to keep the same information and than this `currentIdentifiers` was being synced. This was not ideal solution which might fail when there are multiple updates at the same time as well as it might not trigger update correctly when just editing set object. This commit only uses one source of the truth and uses updater callback to make sure the list is always correctly updated.
marusak
force-pushed
the
logs_updater
branch
2 times, most recently
from
1f10e69 to
d957bb9
Compare
martinpitt
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source of the truth should be
currentIdentifiersas defined inlogs.jsx.logsJournal.jsxhad separate object to keep the same information andthan this
currentIdentifierswas being synced. This was not idealsolution which might fail when there are multiple updates at the same
time as well as it might not trigger update correctly when just editing
set object.
This commit only uses one source of the truth and uses updater callback
to make sure the list is always correctly updated.