Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users: Disable "locked" checkbox when no info is available #20135

Merged

Conversation

mvollmer
Copy link
Member

@mvollmer mvollmer commented Mar 4, 2024

Fixes: #19822

@mvollmer mvollmer requested review from jelly and martinpitt March 4, 2024 15:12
@mvollmer
Copy link
Member Author

mvollmer commented Mar 4, 2024

so let's use the "checked" property which renders a null value as unchecked.

Turns out that was wishful thinking. It doesn't do anything... not sure what it is for.

@mvollmer mvollmer force-pushed the accounts-never-partial-checkbox branch from 3c75d97 to 698d3c8 Compare March 4, 2024 15:27
@mvollmer mvollmer changed the title users: Never show a partial "locked" checkbox users: Disable "locked" checkbox when no info is available Mar 4, 2024
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's not obvious whether it fixes the flake, i.e. whether the race condition is that the b.wait_visible("#account-locked:not([disabled])") was just not waiting long enough (which that PR would fix), or whether it was bouncing due to a series of events and re-renders. But the weather report will tell! This is a good change either way.

@martinpitt martinpitt merged commit 258ca03 into cockpit-project:main Mar 5, 2024
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestAccounts.testBasic pixel flake with checkbox
2 participants