workflows: Drop COCKPITUOUS_TOKEN from trigger-anaconda.yml, update Anaconda trigger for -webui split #19630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cockpit-project/bots#5569 changed the allowlist from a GitHub team to a hardcoded Python list, so we don't need the cockpituous token privilege with its `read:org` any more.
There are more rare tracer failures on RHEL 8 which break unrelated tests randomly. Ignore all crashes in it. We have explicit tests for tracer functionality which will fail if it ever starts to fail for actual updates detection.
martinpitt
added
blocked
martinpitt
added
the
.github-changes
Since https://github.com/cockpit-project/bots/pull/5524/files rhinstaller/anaconda was an unknown project. Update it for the webui split-out.
github-actions
bot
removed
the
.github-changes
allisonkarlitskaya
removed
the
blocked
|
Your attempted validation didn't work as expected: Cloning into 'bots'... but this check happens after the permissions check, so ... success? |
martinpitt
added
blocked
|
@allisonkarlitskaya Yup, noticed that too. Fixed and restarted. |
martinpitt
changed the title
martinpitt
removed
the
blocked
|
That's better Run git clone --depth=1 https://github.com/cockpit-project/bots |
|
@allisonkarlitskaya yes, I linked the successful logs from the description |
allisonkarlitskaya
approved these changes
Nov 20, 2023
| # the default workflow token cannot read our org membership, for deciding who is allowed to trigger tests | ||
| environment: gh-cockpituous | ||
| permissions: | ||
| contents: read |
There was a problem hiding this comment.
I believe that's redundant. Doesn't hurt, though.
|
I'll drop the secret, as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cockpit-project/bots#5569 changed the allowlist from a GitHub team to a hardcoded Python list, so we don't need the cockpituous token privilege with its
read:organy more.I also piggy-backed a fix for this flake