Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Console printing improvements #19585

Merged
merged 5 commits into from
Nov 8, 2023
Merged

test: Console printing improvements #19585

merged 5 commits into from
Nov 8, 2023

Conversation

mvollmer
Copy link
Member

@mvollmer mvollmer commented Nov 8, 2023

No description provided.

@mvollmer mvollmer requested a review from martinpitt November 8, 2023 07:49
martinpitt
martinpitt previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd like to see this improved a bit, but depending on your mood/patience this is already better than the status quo.

test/common/chromium-cdp-driver.js Outdated Show resolved Hide resolved
@mvollmer mvollmer force-pushed the test-failsafe-console-printing branch from 6b6dbed to a3cbfcf Compare November 8, 2023 09:13
martinpitt
martinpitt approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The commits are over-split now, and some are clearly FIXUPs. But if this goes green, I'm fine with squashing them all together.

@martinpitt martinpitt merged commit 80fca0f into cockpit-project:main Nov 8, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvollmer @martinpitt