Skip to content

Commit

Permalink
HACKING: Keep your PR!
Browse files Browse the repository at this point in the history
We've seen contributors close their PRs after each review and open a new
one. Don't do that.
  • Loading branch information
martinpitt committed Feb 7, 2024
1 parent 2a26eb4 commit e8967c5
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions HACKING.md
Original file line number Diff line number Diff line change
Expand Up @@ -378,14 +378,18 @@ A local cache is maintained in `~/.cache/cockpit-dev`.
Make a pull request on github.com with your change. All changes get reviewed,
tested, and iterated on before getting into Cockpit. The general workflow is
described in the [wiki](https://github.com/cockpit-project/cockpit/wiki/Workflow).
Don't feel bad if there's multiple steps back and forth asking for changes or
tweaks before your change gets in.

You need to be familiar with git to contribute a change. Do your changes
on a branch. Your change should be one or more git commits that each contain one
single logical simple reviewable change, without modifications that are
unrelated to the commit message.

Don't feel bad if there's multiple steps back and forth asking for changes or
tweaks before your change gets in. If you fix your commits after getting a
review, just force-push to your branch -- this will update the pull request
automatically. Do *not* close it and open a new one; that would destroy the
conversation and reviews.

Cockpit is a designed project. Anything that the user will see should have
design done first. This is done on the wiki and mailing list.

Expand Down

0 comments on commit e8967c5

Please sign in to comment.