Skip to content

Commit

Permalink
tools: Fix pam_listfile PAM stage
Browse files Browse the repository at this point in the history
This should be in "account" (aka. "denied access"), not "auth" (aka.
"provided wrong credentials"). Thanks to Stephen Gallagher for pointing
out!
  • Loading branch information
martinpitt committed Mar 13, 2024
1 parent 4c7be12 commit ba611be
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tools/arch/cockpit.pam
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#%PAM-1.0
auth include system-remote-login
# List of users to deny access to Cockpit, by default root is included.
auth required pam_listfile.so item=user sense=deny file=/etc/cockpit/disallowed-users onerr=succeed
account required pam_listfile.so item=user sense=deny file=/etc/cockpit/disallowed-users onerr=succeed
account include system-remote-login
password include system-remote-login
session include system-remote-login
2 changes: 1 addition & 1 deletion tools/cockpit.debian.pam
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ auth required pam_sepermit.so
auth substack common-auth
auth optional pam_ssh_add.so
# List of users to deny access to Cockpit, by default root is included.
auth required pam_listfile.so item=user sense=deny file=/etc/cockpit/disallowed-users onerr=succeed
account required pam_listfile.so item=user sense=deny file=/etc/cockpit/disallowed-users onerr=succeed
account required pam_nologin.so
account include common-account
password include common-password
Expand Down
2 changes: 1 addition & 1 deletion tools/cockpit.pam
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ auth substack password-auth
auth include postlogin
auth optional pam_ssh_add.so
# List of users to deny access to Cockpit, by default root is included.
auth required pam_listfile.so item=user sense=deny file=/etc/cockpit/disallowed-users onerr=succeed
account required pam_listfile.so item=user sense=deny file=/etc/cockpit/disallowed-users onerr=succeed
account required pam_nologin.so
account include password-auth
password include password-auth
Expand Down

0 comments on commit ba611be

Please sign in to comment.