Skip to content

Commit

Permalink
test: don't wait twice for wait_not_in_text
Browse files Browse the repository at this point in the history
The test function `wait_not_in_text` already calls `wait_visible` so we
end up waiting twice.
  • Loading branch information
jelly committed Mar 14, 2024
1 parent 82d8b5e commit 9065aca
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test/verify/check-users
Original file line number Diff line number Diff line change
Expand Up @@ -1132,7 +1132,6 @@ class TestAccounts(testlib.MachineCase):
b.wait_text("#group-confirm-delete-dialog footer .pf-v5-c-button.apply", "Delete")
b.click("#group-confirm-delete-dialog footer .pf-v5-c-button.apply")
b.wait_not_present('#group-confirm-delete-dialog')
b.wait_visible("#groups-list")
b.wait_not_in_text('#groups-list', "testgroup0")

# Add testgroup0 back
Expand All @@ -1145,7 +1144,6 @@ class TestAccounts(testlib.MachineCase):
b.click("#group-confirm-delete-dialog footer .pf-v5-c-button.apply")
b.wait_not_present('#account-confirm-delete-dialog')
b.wait(lambda: "#/" == b.eval_js('window.location.hash'))
b.wait_visible("#groups-list")
b.wait_not_in_text('#groups-list', "anton")

b.click('#accounts-list td[data-label="Username"] a[href="#/admin"]')
Expand Down

0 comments on commit 9065aca

Please sign in to comment.