Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Adjust to cockpituous' new pytest #6126

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Mar 21, 2024

run-local.sh was replaced with pytest. See cockpit-project/cockpituous#606


The first version has an additional test commit e75b0f4 which breaks image-download. The test failed , proving that it actually uses the branch from the PR.

@martinpitt
Copy link
Member Author

OK, so the tests failed in the right way, test_images and the mock image refresh stumbled over the crashing image-download. Dropping the test commit.

@martinpitt martinpitt marked this pull request as ready for review March 21, 2024 16:29
@allisonkarlitskaya allisonkarlitskaya merged commit 5ab1de5 into main Mar 21, 2024
5 checks passed
@allisonkarlitskaya allisonkarlitskaya deleted the pytest branch March 21, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants