-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add customization script for fleet.ks in rhel4edge iso file #5810
Conversation
1e55718
to
bc1e134
Compare
@allisonkarlitskaya Hi Lis. Is it possible to install and run |
@jscotka that doesn't work, sorry. Our bots run themselves in (unpriv) podman containers. This needs to be done some other way, perhaps fetching fleet.ks from its originating git? |
Hi @martinpitt , I expected that, So that I have to use original tooling without container, Is It possible to ask to install some package inside this container? Or I should try to use copletely another solution? IT Is not just about extracting fleet.ks, but also give them back to ISO a tweak ISO file little bit, I have to look at all necessary changes. |
@jscotka Yes, we can add packages to the container, see https://github.com/cockpit-project/cockpituous/blob/main/tasks/Containerfile . |
Last commit with rebase depends on changes in cockpit-project/cockpituous#571 |
mv "$ISO_FILE" "$DIR_NAME/fleet_source.iso" | ||
chmod 775 "$DIR_NAME" | ||
# extract fleet.ks to directory | ||
xorriso -osirrox on -indev "$DIR_NAME/fleet_source.iso" -extract /fleet.ks "$DIR_NAME/fleet.ks" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also do this with isoinfo -x
, that tool is already in the tasks container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please give some high-level description of what you are trying to do here? It's not clear from the code changes, they seem unrelated to fixing the anaconda hang.
Thanks for looking into it!
sed -i "s@BASEDIR=.*@BASEDIR='$DIR_NAME'@" "$DIR_NAME/fleetkick.sh" | ||
mkdir "$DIR_NAME/workdir" | ||
|
||
$DIR_NAME/fleetkick.sh -w "$DIR_NAME/workdir" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just about everything about this is wrong: Conceptually we are not testing the built rhel4edge image, but a heavily hacked rebuild of it. Operationally, this is untrusted arbitrary code execution inside the RH network with access to secrets.
Customizations should happen either via a kickstart file (which then runs inside the built VM), which can be served over local http instead of using the existing fleet.ks
on the image; or as virt-install arguments in images/scripts/virt-install-rhel4edge; or perhaps edge-request.json has some customization options here?
replaced by version with custom kickstart, seems to work well, at least for now #5825 |
Image refresh for rhel4edge