Refactor pending diff handling: don't miss any diffs #536
+300
−211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… diff loop and make clearing of pending diffs atomic
…log and degrade some info logs to debug
…verything still works
jhweir
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This coalesces the new commit debouncing code introduced in #533 with the old pending diff handling in a proper way, as to not accidentally miss committing any diffs.
Ad4mDb::get_pending_diffs()andAd4mDb::clear_pending_diffs()now work with the DB ids of each of the diffs, so that we only remove diffs that actually were committed, avoiding race conditions between different threads dealing with pending diffs.